-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not add pay later button in editor (3535) #2570
Conversation
Hey there, just checking up on this PR as it was ready to merge a month ago? Is there a reason it hasn't yet? \cc @InpsydeNiklas |
@alexflorisca We found some remaining edge-case issues where incorrect buttons were displayed in the editor, which seemed more difficult to resolve. However, we merged this now and will include it with #2448 in the upcoming 2.9.4 update. |
Thanks @InpsydeNiklas. Just to be annoying, I think the best UX would be to render the PayLater button as a separate button, if it's enabled in the backend. Otherwise the merchant and shopper UX will be different! (You can see similar discrepancies with WooPayments too). It would be great to address this too. |
@alexflorisca I completely agree! Disabling the non-PayPal buttons (which also includes Venmo) is more of a temporary workaround to prevent the layout in the editor from breaking. |
Splitting may be possible (or we can try again to use the same library as in frontend), but the main problem is determining which buttons are available (e.g. for the merchant/shop country). In frontend we use woocommerce-paypal-payments/modules/ppcp-blocks/resources/js/checkout-block.js Lines 826 to 845 in 0b6e04d
So unless there is a way to get something like |
In 4e34332 we removed all APMs in editor because it is difficult to determine which APMs are available when registering buttons separately in editor,
canMakePayment
does not work there.But
fundingSource
was not set topaypal
, so it could still render at least Pay Later button (in the same express payment method cell, breaking layout when there are other methods).Fixed that, now only one PayPal button can be shown in editor.